Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasette publish Dockerfile should use python:3.6-slim-stretch #297

Closed
simonw opened this issue May 29, 2018 · 1 comment
Closed

datasette publish Dockerfile should use python:3.6-slim-stretch #297

simonw opened this issue May 29, 2018 · 1 comment

Comments

@simonw
Copy link
Owner

simonw commented May 29, 2018

Right now the Dockerfile generated by datasette package and datasette publish uses this:

FROM python:3

This appears to result in a SQLite version of 3.8.7.1 - https://parlgov.datasettes.com/-/versions

    "sqlite": {
        "extensions": {},
        "fts_versions": [
            "FTS4",
            "FTS3"
        ],
        "version": "3.8.7.1"
    }

Meanwhile, https://fivethirtyeight.datasettes.com/-/versions is deployed with this Dockerfile https://github.com/simonw/fivethirtyeight-datasette/blob/0849901cae06e957fe04892cd4033bdcd1fcf966/Dockerfile which uses FROM python:3.6-slim-stretch and results in the following version report:

    "sqlite": {
        "extensions": {
            "json1": null
        },
        "fts_versions": [
            "FTS5",
            "FTS4",
            "FTS3"
        ],
        "version": "3.16.2"
    }

So not only do we get a more recent SQLite (including https://www.sqlite.org/rowvalue.html added in 3.15) but we also get FTS5 and json1 as well.

Refs #191

@simonw
Copy link
Owner Author

simonw commented May 31, 2018

I fixed this in b18e451

@simonw simonw closed this as completed May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant