/-/versions for official Docker image returns wrong Datasette version

[simonw]

docker run -p 8001:8001 datasetteproject/datasette datasette -p 8001 -h 0.0.0.0

http://0.0.0.0:8001/-/versions returns this:

{
    "datasette": {
        "version": "0+unknown"
    },
    ...

This is because the Docker image is built by copying in the Datasette source code, which confuses versioneer. Maybe the Docker image should install the code using a wheel or similar?

[simonw]

It looks like there are two reasons for this:

• The .git directory was listed in .dockerignore so it wasn't being copied into the build process
• The docker build stage wasn't installing the git executable, so it couldn't read the current version

[simonw]

docker pull datasetteproject/datasette
docker run -p 8001:8001 datasetteproject/datasette datasette -p 8001 -h 0.0.0.0

http://0.0.0.0:8001/-/versions now returns:

{
    "datasette": {
        "version": "0.26.2+0.ga418c8b.dirty"
    },

I'm not sure why it's showing .dirty there.