Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable browser caching for plugin statics with datasette-auth #586

Closed
simonw opened this issue Oct 7, 2019 · 2 comments
Closed

Enable browser caching for plugin statics with datasette-auth #586

simonw opened this issue Oct 7, 2019 · 2 comments
Labels
bug

Comments

@simonw
Copy link
Owner

simonw commented Oct 7, 2019 •
edited
Loading

An authenticated Datasette I run is seeing delays on every page load. On looking at the network inspector it turns out it's because datasette-vega is nearly 1MB and a cache-control: private is preventing it from being cached!

github__repos__32_rows_where_where_private___1

This may well turn out to be a bug in datasette-auth-github but it's still worth tracking here because caching of static assets from plugins is very important.
@simonw simonw added the bug label Oct 7, 2019
@simonw simonw mentioned this issue Oct 7, 2019
Closed
@simonw
Copy link
Owner Author

simonw commented Oct 7, 2019

Yes this is the fault of datasette-auth-github:

https://github.com/simonw/datasette-auth-github/blob/b3aaa4cc2f9b05a480357727bdce39c57d56fd4c/datasette_auth_github/github_auth.py#L138-L145

Bug filed over there: simonw/datasette-auth-github#47

@simonw
Copy link
Owner Author

simonw commented Oct 7, 2019

Fixed in datasette-auth-github and shipped as the 0.10 release of that plugin.

@simonw simonw closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw