Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish heroku should default to currently tagged version #765

Open
simonw opened this issue May 11, 2020 · 1 comment
Open

publish heroku should default to currently tagged version #765

simonw opened this issue May 11, 2020 · 1 comment

Comments

@simonw
Copy link
Owner

simonw commented May 11, 2020

Had a report that deploying to Heroku was using the previously installed version of Datasette, not the latest.

Could be because of this:

if branch:
install = [
"https://github.com/simonw/datasette/archive/{branch}.zip".format(
branch=branch
)
] + list(install)
else:
install = ["datasette"] + list(install)

Heroku documentation recommends pinning to specific versions https://devcenter.heroku.com/articles/python-pip

So... we could ensure we default to an install value of ["datasette>=current_tag"].

@simonw
Copy link
Owner Author

simonw commented May 11, 2020

Trickiness here is what tag to use. Do we use the tag of the installed copy of Datasette that is running datasette publish? That would mean you don't get the latest features in your deployed release.

Could hit an API to figure out the most recent version? Bit odd.

Could we output the version of Datasette that was deployed and tell people they can run --latest to force the most recent release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant