Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static assets and favicon aren't cached by the browser #974

Open
obra opened this issue Sep 24, 2020 · 1 comment
Open

static assets and favicon aren't cached by the browser #974

obra opened this issue Sep 24, 2020 · 1 comment

Comments

@obra
Copy link

obra commented Sep 24, 2020

Using datasette to solve some frustrating problems with our fulfillment provider today, I was surprised to see repeated requests for assets under /-/static and the favicon. While it won't likely be a huge performance bottleneck, I bet datasette would feel a bit zippier if you had Uvicorn serving up some caching-related headers telling the browser it was safe to cache static assets.

@simonw
Copy link
Owner

simonw commented Sep 24, 2020

Come to think of it I've noticed that in the logs when it's running on my laptop, definitely worth fixing.

@simonw simonw added this to the Datasette 0.52 milestone Nov 1, 2020
@simonw simonw modified the milestones: Datasette 0.52, Datasette Next Nov 28, 2020
@simonw simonw removed this from the Datasette Next milestone Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants