-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcr-picker position, CSS size override and percents #53
Comments
Thanks, I'm glad you like it :) Regarding to the first issue with CSS Overrides, wow - that's a really strange issue. Seem's like the browser applies some styles later than others. Anyway, it works if I wrap the first color-applying stuff into a To the second one, it works... at least on Chrome |
Oops, I'm a little bit confused about the second issue. Tried it in Chrome (canary and stable) and Firefox. Either this problem has been solved with the other bug fix, or I just used browsers in which this issue in particular isn't present. Which browser did you use? |
After your fix it works fine. You can close this issue :3 Thank you again |
You're welcome :) |
Hello! You did a great job, your colorpicker is awesome.
But, here is some issues. It's about pcr-app size.
1 - CSS Override.
If I set only .pcr-app class height, pcr-picker position is correct.
( here is a demo http://jsfiddle.net/o3e5wqc7/7/ )
If I set .pcr-app height as child of any tag, pcr-picker position is correct.
( here is a demo http://jsfiddle.net/o3e5wqc7/8/ )
If I set .pcr-app height as child of any class, pcr-picker position is INCORRECT.
(It takes a value of default style 240px)
( here is a demo http://jsfiddle.net/o3e5wqc7/9/ )
2 - Size in percents
I need to set height on .pickr and .pcr-app in percents, there is always position: 0 0 after intialization.
( here is a demo http://jsfiddle.net/o3e5wqc7/10/ )
I hope this is not a feature, but just an annoying little bug :)
The text was updated successfully, but these errors were encountered: