Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcr-picker position, CSS size override and percents #53

Closed
Evangeline-Rei opened this issue Dec 31, 2018 · 4 comments
Closed

pcr-picker position, CSS size override and percents #53

Evangeline-Rei opened this issue Dec 31, 2018 · 4 comments
Labels
bug Something isn't working unconfirmed The problem isn't really clear

Comments

@Evangeline-Rei
Copy link

Evangeline-Rei commented Dec 31, 2018

Hello! You did a great job, your colorpicker is awesome.
But, here is some issues. It's about pcr-app size.

1 - CSS Override.
If I set only .pcr-app class height, pcr-picker position is correct.
( here is a demo http://jsfiddle.net/o3e5wqc7/7/ )

If I set .pcr-app height as child of any tag, pcr-picker position is correct.
( here is a demo http://jsfiddle.net/o3e5wqc7/8/ )

If I set .pcr-app height as child of any class, pcr-picker position is INCORRECT.
(It takes a value of default style 240px)
( here is a demo http://jsfiddle.net/o3e5wqc7/9/ )

2 - Size in percents
I need to set height on .pickr and .pcr-app in percents, there is always position: 0 0 after intialization.
( here is a demo http://jsfiddle.net/o3e5wqc7/10/ )

I hope this is not a feature, but just an annoying little bug :)

@simonwep
Copy link
Owner

Thanks, I'm glad you like it :)

61218252 1

Regarding to the first issue with CSS Overrides, wow - that's a really strange issue. Seem's like the browser applies some styles later than others. Anyway, it works if I wrap the first color-applying stuff into a requestAnimationFrame, see cfbc278.

To the second one, it works... at least on Chrome 71.0.3578.98. I'll test it later on other browsers!

@simonwep simonwep added the bug Something isn't working label Dec 31, 2018
@simonwep simonwep closed this as completed Jan 9, 2019
@simonwep simonwep reopened this Jan 9, 2019
@simonwep
Copy link
Owner

simonwep commented Jan 9, 2019

Oops, I'm a little bit confused about the second issue. Tried it in Chrome (canary and stable) and Firefox. Either this problem has been solved with the other bug fix, or I just used browsers in which this issue in particular isn't present. Which browser did you use?

@simonwep simonwep added the unconfirmed The problem isn't really clear label Jan 13, 2019
@simonwep simonwep added the awaiting response OP hasn't answered yet label Feb 13, 2019
@Evangeline-Rei
Copy link
Author

Evangeline-Rei commented Feb 16, 2019

After your fix it works fine. You can close this issue :3 Thank you again

@simonwep
Copy link
Owner

You're welcome :)

@simonwep simonwep removed the awaiting response OP hasn't answered yet label Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed The problem isn't really clear
Projects
None yet
Development

No branches or pull requests

2 participants