New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oauth for Untappd not working #262
Comments
I got the debugging working, looks like it is already with the authorization_code where it goes wrong: a POST request is send to Untappd, which should be a GET request. Is it possible to change that in the configuration?
|
Yes, it have to be implemented here, I can do it, it's fairly easy. |
Oh that would be great! |
Can you pull master and test it? It was implemented here d09f94e Unfortunately I don't have an app to test it and it seems that one of the parameters may still be incorrect. Note that their implementation is outside of the OAuth spec. |
That's fast! I've pulled the changes and started a express server. But I seem to get the following error:
I tested with the following:
And the following js code:
After going to the /connect/untappd URL I get the error as shown above. With DEBUG logs I see that a GET request has been send and a status 200 OK was send back, including the code. |
Edit: In English By the way, I think you miss the following parameter
According to the documentation, this parameter should be send with both requests. So: |
Ok, I'm adding it. That was the one that I was not sure about .. usually that's not being sent with that request. |
Yeah, the OAuth implementation is not really according to the specs |
Updated here 111e7d3 let me know if it works. |
Well it seems they are sending back just the access token instead of what they claim in their docs: {
"meta": {
"http_code": 200
},
"response": {
"access_token": "TOKEHERE"
}
} Ok .. yet another update incoming. |
Updated here ea29993 lets see. |
Thanks, will check tomorrow! |
Yes, it's working! I get the following back:
|
It's working with transport methods querystring & session. I cannot get 'state' to work, but that's I think more to do with my testsetup, so for now I think this item can be closed! |
Nice, we can keep this open until I publish the next release. |
Published in v5.4.18 |
Hi all! I'm using Strapi for a personal BeerApp project, and I'm trying to get Oauth2 for Untappd working. At the moment however, I don't seem to send the correct values to Untappd, as I'm getting indications that I'm not sending the required params in the URL.
I have the following Grant configuration:
I am getting back the 'code' parameter to the callback URL, but after that it doesn't work. Untappd requires a GET request to get the access_token back with the following parameters:
However, I get the message from Untappd:
I already tried to use the
token_endpoint_auth_method: "client_secret_basic"
, as to my understanding Grant is using a POST request to get the access_token, right? But adding this option to the config this doesn't change anything.Does anyone have a clue what to do?
The text was updated successfully, but these errors were encountered: