Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github oauth: redirect_ui mismatch #31

Closed
marcelklehr opened this issue Aug 30, 2015 · 4 comments
Closed

Github oauth: redirect_ui mismatch #31

marcelklehr opened this issue Aug 30, 2015 · 4 comments

Comments

@marcelklehr
Copy link

Hey,

I'm using grant for github auth in my app and the redirect uri seems to equal myapp.com/connect/github/callback&state= instead of myapp.com/connect/github/callback.

Here's my config:

{
    server: {
      protocol: 'http'
    , host: 'http://myapp.org'
    }
  , github: {
      key: 'key'
    , secret: 'secret'
    , scope: []
    , callback: '/login_github_callback'
    }
  }
@simov
Copy link
Owner

simov commented Aug 30, 2015

It should be host:'myapp.org'

Here is what I have set up for Authorization callback URL of my OAuth app here on GitHub (for the OAuth Playground):

https://grant-oauth.herokuapp.com/connect/github/callback

Then in my config I have:

server:{protocol:'https', host:'grant-oauth.herokuapp.com'},
github:{key, secret, scope ...}

@marcelklehr
Copy link
Author

ah, works now. Thank you!

@marcelklehr
Copy link
Author

Awesome project by the way!

@simov
Copy link
Owner

simov commented Aug 31, 2015

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants