Avoid using mutables as default parameters #1142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
flake8
B006
warnings. Avoid using mutables as default values forfunction and methods parameters. Default function parameters are
evaluated only once during function definition. If those default values
are mutable variables it's possible that the function call might change
it, leading to a "new default" value on subsequent function calls.
Use tuples instead of lists and None for dictionaries (the default value
could be defined inside the body through a quick
is None
check).Remove
B006
from the ignored warnings inMakefile
.This article has good explanations of why using mutable default values is discouraged.