Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DC - instantiating sources and receivers #877

Closed
lheagy opened this issue May 25, 2020 · 3 comments · Fixed by #884
Closed

DC - instantiating sources and receivers #877

lheagy opened this issue May 25, 2020 · 3 comments · Fixed by #884
Labels
DC

Comments

@lheagy
Copy link
Member

lheagy commented May 25, 2020

rather than locationA or locationsM, I would suggest that we use a_location and m_locations for instantiating sources and receivers. These also should be allowed to be None in the case that the user wants to input locations as a 2D array (which will happen when we deserialize a survey)
@jcapriot
Copy link
Member

jcapriot commented May 25, 2020 •
edited

I agree with this! I had some of my own thoughts in my head the other day about this.
I kinda want the class to be able to be instantiated by either:

rx.Dipole(locations=(locs_m, locs_n)) or rx.Dipole(m_locations=locs_m, n_locations=locs_n)

@lheagy
Copy link
Member Author

lheagy commented May 25, 2020

👍 I really like that!

@lheagy
Copy link
Member Author

lheagy commented May 25, 2020

I started this on the transform-dc-updates branch

@lheagy lheagy mentioned this issue May 25, 2020
Closed
@lheagy lheagy added the DC label May 25, 2020
@lheagy lheagy mentioned this issue May 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transform dc updates simpeg/simpeg
2 participants
@lheagy @jcapriot