Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

EM1DSurveyTD instantiation depends on layer depths #20

Open
leonfoks opened this issue Sep 5, 2018 · 1 comment
Open

EM1DSurveyTD instantiation depends on layer depths #20

leonfoks opened this issue Sep 5, 2018 · 1 comment

Comments

@leonfoks
Copy link

leonfoks commented Sep 5, 2018

This is a design issue / feature request I think.

The EM1DSurveyTD requires the model depths in order to instantiate. I think the survey class should be independent of the subsurface structure, which would make more sense from a programmatic stand point. I would suggest removing the depth argument, of course there are repercussions down the line in doing so.

I'm sure this was done under the assumption that the model structure stays the same, and hence you can garner some efficiencies. In our case, we change our number of layers at every iteration, so (i think) we have to re-instantiate the Survey class for every forward model.

@sgkang
Copy link
Contributor

sgkang commented Oct 17, 2018

Good suggestion. It is a general issue in SimPEG problem, and there is an initiative to change this. We'll keep you posted about this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants