Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ontology installation to CI tests #683

Open
pablo-de-andres opened this issue Aug 6, 2021 · 3 comments
Open

Add ontology installation to CI tests #683

pablo-de-andres opened this issue Aug 6, 2021 · 3 comments
Labels
ℹ️ best practices pico Issue affecting the PICO ontology installer. 📜 ontology 💉 testing Solving the issue involves creating/modifying unit tests or benchmarks.

Comments

@pablo-de-andres
Copy link
Member

Marketplace's current version of OSP-core used (ce16cb8) fails when trying to install EMMO. This should have been detected automatically by the tests.

I would suggest automatically attempting to install one or two ontologies in the CI to make sure the installation process works as expected
@pablo-de-andres pablo-de-andres added ℹ️ best practices 🚧 installation Issues affecting the package installation. NOT related to the installation of ontologies. 📜 ontology pico Issue affecting the PICO ontology installer. 💉 testing Solving the issue involves creating/modifying unit tests or benchmarks. labels Aug 6, 2021
@kysrpex kysrpex removed the 🚧 installation Issues affecting the package installation. NOT related to the installation of ontologies. label Aug 12, 2021
@kysrpex
Copy link
Contributor

kysrpex commented Apr 7, 2022

This should be solved now with test_installation.py, right?

@pablo-de-andres
Copy link
Member Author

Does this only test the installation of city, or also all the other included ontologies?

My point was that if we include some popular ontologies for easier installation, we should make sure they can actually be installed.

@kysrpex
Copy link
Contributor

kysrpex commented Apr 7, 2022

Does this only test the installation of city, or also all the other included ontologies?

My point was that if we include some popular ontologies for easier installation, we should make sure they can actually be installed.

It does not include the installation of all the other included ontologies, so I will leave this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ℹ️ best practices pico Issue affecting the PICO ontology installer. 📜 ontology 💉 testing Solving the issue involves creating/modifying unit tests or benchmarks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pablo-de-andres @kysrpex