Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh: add checking of attribute-values (=values of data properties) #828

Closed
MBueschelberger opened this issue Oct 13, 2022 · 0 comments · Fixed by #830
Closed

Enh: add checking of attribute-values (=values of data properties) #828

MBueschelberger opened this issue Oct 13, 2022 · 0 comments · Fixed by #830
Assignees
Labels
data model 📜 ontology 🌱 new feature Solving the issue involves the incorporation of a new feature.

Comments

@MBueschelberger
Copy link
Member

As a follow-up of #821, I was also asked for the functionality to check the actual values of the Cuds.

For my opion this makes absolutely sense if you want to write a unittest for your function which is generating Cuds with actual data.

However, my suggestion would be that this might also overwrite the cardinality with a value-keyword in the case of data properties:

Restriction to length

city.Neighborhood:
    city.name:
        STRING:
            value: 1+

Following a similar pattern as the cardinality, this value might e.g. in case of a string restrict the length (see example above) or the actual value:

Restriction of value

city.Neighborhood:
    city.name:
        STRING:
            value: Stühlinger

In the case of floats, bools and ints, there is no restriction of the length needed, but rather a statement towards the data range:

Restriction of range

city.Citizen:
    city.age:
        INTEGER:
            value: 0+

... or the actual value:

Restriction of value

city.Citizen:
    city.age:
        INTEGER:
            value: 29
    city.name:
        STRING:
            value: Matthias

In case of vectors, length, data range and value restriction might be a bit more complicated. But I think this is not a huge priority to be implemented since we are ontologizing in the EMMO-way, without any vectors as data properties.

@MBueschelberger MBueschelberger added data model 🌱 new feature Solving the issue involves the incorporation of a new feature. 📜 ontology labels Oct 13, 2022
@MBueschelberger MBueschelberger self-assigned this Oct 13, 2022
@kysrpex kysrpex linked a pull request Dec 6, 2022 that will close this issue
@kysrpex kysrpex closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data model 📜 ontology 🌱 new feature Solving the issue involves the incorporation of a new feature.
Projects
None yet
2 participants