You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A clear and concise description of what the bug is
When using '/sim serial stop' and then '/sim serial stop', the function initPorts is called. This function redefine all the elements of onSerialReceivedArray. This mean that all the callback that are defined are erased. This break the SimPit functions that listen for input from Arduino. We need to reload the game to restore those functionalities.
To Reproduce
Launch KSP and load a mission
Type '/sim serial stop'
Type '/sim serial start'
Restart the Arduino
Try to use functions to send data to KSP : it is not registered. Reloading the game solve the issue.
To Solve
When stopping and restarting serial connection, the connection itself should be reset but all the callbacks should not be erased.
The text was updated successfully, but these errors were encountered:
PBechon
changed the title
[BUG]:
[BUG]: Serial stop/start does not restore all functionalities
Dec 17, 2020
I have pushed the branch fix/fix-serial-reconnection that should do the trick. There were a couple of things in there that I needed to tweak that prevented the reconnecting controller from binding as intended.
Description of the bug
Mod version: current develop branch
Game version: 1.10
Operating system: Windows
A clear and concise description of what the bug is
When using '/sim serial stop' and then '/sim serial stop', the function initPorts is called. This function redefine all the elements of onSerialReceivedArray. This mean that all the callback that are defined are erased. This break the SimPit functions that listen for input from Arduino. We need to reload the game to restore those functionalities.
To Reproduce
To Solve
When stopping and restarting serial connection, the connection itself should be reset but all the callbacks should not be erased.
The text was updated successfully, but these errors were encountered: