Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: No SOI message at initialisation #42

Closed
PBechon opened this issue Mar 25, 2021 · 3 comments
Closed

[BUG]: No SOI message at initialisation #42

PBechon opened this issue Mar 25, 2021 · 3 comments

Comments

@PBechon
Copy link
Collaborator

PBechon commented Mar 25, 2021

Based on a report on GitHub : when using the SOI message, it is sent when the SOI change but it is undefined until the first SOI change.

If you launch KSP and load a game, no SOI message is send until a SOI change happen. This prevent displaying the current SOI when the game is launched.

@LRTNZ
Copy link
Collaborator

LRTNZ commented Mar 29, 2021

Should we look at adding some way of sending select messages like the current SOI, when a ship is loaded?
So that the controller can update with all of the values that may change rather infrequently.

@PBechon
Copy link
Collaborator Author

PBechon commented Mar 29, 2021

Based on my finding, the message is sent each time the SOI change for whatever reason (I did not test it, but it should be OK for ship load). The issue was that there is no check that there is a controller receiving the SOI message so when a controller subscribe for the first time, there is no special case to send the first SOI name.
All the ones after that should be OK.

@PBechon
Copy link
Collaborator Author

PBechon commented Apr 28, 2021

Closed as #45 is merged

@PBechon PBechon closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants