CI: Remove yarn caching #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular `yarn install` takes ~23sec. When using caching the cache download takes ~15sec, the `yarn install` then still takes ~13sec, and at the end of the job the cache upload takes another ~36sec. Ultimately this means that caching makes us significantly slower in this case.
marcoow
approved these changes
Sep 15, 2020
|
the caching is mostly worth it if you can reduce CPU bound tasks with it. if it just moves network or disk bound tasks to a different step then it's often not necessary if the cache network connection is as fast/slow as the real network request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regular
yarn installtakes ~23sec. When using caching the cache download takes ~15sec, theyarn installthen still takes ~13sec, and at the end of the job the cache upload takes another ~36sec. Ultimately this means that caching makes us significantly slower in this case.