Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [ember-debug.deprecate-options-missing] on rejectWithXhr deprecationAlias #1170

Merged
merged 1 commit into from Jan 10, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion addon/authenticators/devise.js
Expand Up @@ -78,7 +78,10 @@ export default BaseAuthenticator.extend({
@deprecated DeviseAuthenticator/rejectWithResponse:property
@public
*/
rejectWithXhr: computed.deprecatingAlias('rejectWithResponse'),
rejectWithXhr: computed.deprecatingAlias('rejectWithResponse', {
id: `ember-simple-auth.authenticator.reject-with-xhr`,
until: '2.0.0'
}),

/**
When authentication fails, the rejection callback is provided with the whole
Expand Down
5 changes: 4 additions & 1 deletion addon/authenticators/oauth2-password-grant.js
Expand Up @@ -141,7 +141,10 @@ export default BaseAuthenticator.extend({
@deprecated OAuth2PasswordGrantAuthenticator/rejectWithResponse:property
@public
*/
rejectWithXhr: computed.deprecatingAlias('rejectWithResponse'),
rejectWithXhr: computed.deprecatingAlias('rejectWithResponse', {
id: `ember-simple-auth.authenticator.reject-with-xhr`,
until: '2.0.0'
}),

/**
When authentication fails, the rejection callback is provided with the whole
Expand Down