disable FastBoot tests for now #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know that the FastBoot tests fail currently (and actually have known that for some time, see #1719 but until now nobody was able to fix that). The problem is that they don't just fail but they time out which means that our entire build takes more than 10min still (even if it should now be much faster as we're running it on github actions, see #2034). We could of course decrease the timeout so the build step fails faster but there's no real value in that over just disabling the tests completely for now - they aren't going to fix themselves and just start to work again anyway.
#1719 needs to be worked on though - we really should have proper test coverage that makes sure we're not breaking FastBoot support.