Remove use of the deprecated getWithDefault API #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI the CI failures here don't seem to be related to the change. I reverted the changes on this branch and similar errors still occurred. |
|
Ember 3.21 is out now, probably should merge this soon. |
|
Is there anything I can do to help get this merged? |
Closed
sdebarros
pushed a commit
that referenced
this pull request
Oct 16, 2020
sdebarros
pushed a commit
that referenced
this pull request
Oct 16, 2020
|
Thanks @marcoow & @sdebarros for all your work on this! 3.1 is great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
getWithDefaultis deprecated in Ember 3.21 it's recommended to useget()(if needed) then directly check forundefined.I would have used nullish coalescing but couldn't see any other uses of that in the codebase so decided against it.