Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node 10 in favor of 12 #2313

Merged
merged 1 commit into from Jul 15, 2021

Conversation

BobrImperator
Copy link
Collaborator

@BobrImperator BobrImperator commented Jul 14, 2021

Pipelines are failing to due to some dependencies being incompatible with node 10.
Node 10 also already reach it's end of life.

see #2312

@BobrImperator BobrImperator requested review from marcoow and a team July 15, 2021 12:29
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍 (in particular given Node 10 has reached end of life). Let's just not increment the version in this – we can do that once we release.

@@ -1,6 +1,6 @@
{
"name": "ember-simple-auth",
"version": "3.1.0",
"version": "4.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "4.0.0",
"version": "3.1.0",

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it 👍

@marcoow marcoow merged commit ae243db into mainmatter:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants