Update "deprecate" to import from @ember/debug #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
force-pushed
the
sn/debug-deprecation
branch
from
fffd8e6
to
c58d562
Compare
|
Seems like we generally have some test failures that are common across PRs? Are they blocking? |
|
@snewcomer these seem to be related to global Ember usage which has been deprecated for a while, and because of that ember-beta seems to be failing because it's usage must've been removed, not sure atm though. |
marcoow
reviewed
Sep 6, 2021
| @@ -62,7 +62,7 @@ | |||
| "ember-sinon": "~5.0.0", | |||
| "ember-source": "~3.18.0", | |||
| "ember-source-channel-url": "^2.0.1", | |||
| "ember-test-selectors": "^4.0.0", | |||
| "ember-test-selectors": "^6.0.0", | |||
There was a problem hiding this comment.
I was working on getting the tests passing. Looks like they are failing on the main branch so hopefully I can resolve here 👉
This reverts commit 050737e.
BobrImperator
approved these changes
Sep 15, 2021
marcoow
reviewed
Sep 24, 2021
There was a problem hiding this comment.
Would it make sense to update all of the usages of the old import in this PR?
|
@marcoow oh my how I missed that :). Fixed |
|
@snewcomer there are some linter failures now because duplicated imports… |
marcoow
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2315 (comment)