Do not take global as default context but this for AMD distribution (should fix #323) #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoow
changed the title
global as default context but window (should fix #323)
marcoow
changed the title
| var Ember = global.Ember; | ||
| if (typeof Ember === 'undefined' && typeof require !== 'undefined') { | ||
| Ember = require('ember'); | ||
| } |
There was a problem hiding this comment.
The only problem with this is that this is actually a breaking change (I'm not sure whether this will actually affect anybody though.)
There was a problem hiding this comment.
Any idea who could help in this reflexion?
There was a problem hiding this comment.
I'd just leave it as
var Ember = global.Ember;
if (typeof Ember === 'undefined' && typeof require !== 'undefined') {
Ember = require('ember');
}so that if there's an Ember global that is used.
There was a problem hiding this comment.
Can you update this according to my comment above?
|
PR updated |
|
merged f73c60d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea how to test that. Would love to help. :)