Refactor CSS Style Declaration types to support latest TypeScript #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarryThePenguin
commented
Jul 31, 2020
Comment on lines
+27
to
+29
| type CSSStyleDeclarationProperty = keyof CSSStyleDeclaration; | ||
|
|
||
| type ActualCSSStyleDeclaration = Partial<Record<CSSStyleDeclarationProperty, unknown>>; |
There was a problem hiding this comment.
CSSStyleDeclaration requires all properties to be defined
Using Partial allows the assertions to define a subset of CSSStyleDeclaration properties
Using unknown here allows us to get around the issue of CSSStyleDeclaration having properties like readonly length: number; and readonly parentRule: CSSRule | null;
Really, they can be anything as they're passed in by tests as expectedProperties
BarryThePenguin
commented
Jul 31, 2020
| message?: string | ||
| ): DOMAssertions { | ||
| let element = this.findTargetElement(); | ||
| if (!element) return this; | ||
|
|
||
| let computedStyle = window.getComputedStyle(element, selector); | ||
| let expectedProperties = Object.keys(expected) as [keyof CSSStyleDeclaration]; |
There was a problem hiding this comment.
[keyof CSSStyleDeclaration] indicates an array with a single item of keyof CSSStyleDeclaration
Is that deliberate?
Turbo87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a note in your Chagelog about #757
This PR is an attempt at solving any issues caused by the latest version of TypeScript 馃檲
Happy to make any changes needed 馃憢