Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we auto focus? #17

Open
bedeoverend opened this issue May 29, 2017 · 0 comments
Open

Should we auto focus? #17

bedeoverend opened this issue May 29, 2017 · 0 comments
Labels

Comments

@bedeoverend
Copy link
Contributor

In simpla-article, we're focusing the editor before applying any format. Given how much this is repeating things - would it make sense to just auto focus on the editor before any format / embed is used?

This could break things if controlling it imperatively, as it will just clobber focus, even though it might be needing to format / embed imperatively outside of current live selection...I feel like this is the edge case. But it also just feels messy, it doesn't feel like embed / formats should care about where the current focus is.

It'd probably make sense to add an autoFocus prop which is set to true by default, and automatically re-focuses the editor whenever a command is made on it.

cc/ @seaneking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant