Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserting image doesn't preserve selection #9

Closed
madeleineostoja opened this issue May 24, 2017 · 3 comments
Closed

Inserting image doesn't preserve selection #9

madeleineostoja opened this issue May 24, 2017 · 3 comments
Assignees
Labels

Comments

@madeleineostoja
Copy link

Use-case: embed image on first (and only) line of article

Result: Can't focus on anything but the image, because no text nodes are preserved

@bedeoverend
Copy link
Contributor

After discussion IRL:

Easiest option here is to always insert a new line of text after embedding an object

@madeleineostoja
Copy link
Author

Not sure what changed, but this isn't much of an issue any more. It's pretty easy/intuitive to select text around image nodes now. Maybe because images are a top-level node? No idea.

Probably still good to auto-insert an extra line, so it's easier to keep writing after embedding an image (especially for floated images), but lower priority than before.

@madeleineostoja
Copy link
Author

Ohh it's because I added padding to the article demos, so it's easy to select node immediately left/right of image. Welp, can't rely on that. So this is still breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants