Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element imports shouldn't default to async #46

Closed
madeleineostoja opened this issue Nov 28, 2016 · 1 comment
Closed

Element imports shouldn't default to async #46

madeleineostoja opened this issue Nov 28, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@madeleineostoja
Copy link

Currently Simpla imports its elements with the async, which makes their requests non-blocking. This is incorrect behaviour, and worsens the FOUC you get when Simpla's content 'pops' into place. They should instead default to be blocking, like styles and scripts in the head are, and if a user wants to have them async and handle the FOUC themselves, then they can import manually.

This also becomes redundant once #35 is shipped, as we'll be stripping out auto-imports (it will just become a matter of what we document as the recommended practice).

@madeleineostoja
Copy link
Author

This is redundant in v2 (see 2.0-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants