-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font assets not included in PHP package #186
Comments
why have the composer package then? shrug your readme will need updated because it suggests its one and done with composer. right now it says, install with composer, then see manual setup instructions. manual setup instructions say dl dist and link to css file. which does not exist in composer package. so why have the package if we are to just download the dist anyway. 🙃 |
Sorry I haven't understood what you was trying to said. You're right, the distribution folder is not generated before we "upload" to Packagist. I'm not sure how can we upload these assets to Packagist as they just release the tag pushed to Github, just supposing that we need to include the distribution folder in the tag which is... strange IMHO? Not sure. This problem can be checked downloading manually the latest version through this URL. Unfortunately I don't have time to work on this nor motivation as I haven't used PHP in my whole life. This integration was added by a developer that is no longer part of the Simple Icons maintainers team. If someone want to bring a solution feel free to open a PR. |
alright, i'll hit up my composer buddies for suggestions before i submit an idea with a sledgehammer that could have been a screwdriver. |
after discussing with some peeps about what we're used to seeing in our corner of the eco system i got back three main ideas. none of these are demands just what i got back in my polling.
|
The solution is much more simpler but I don't have the motivation to do it testing it manually. Just add a step to the publish workflow (after this step) to build the fonts before tagging the release, including the generated distribution folder (dist/) on the tag. After that, the fonts will be included in the Packagist package. |
is the composer package meant to include pre-compiled css and font files? the instructions here were pretty spartan and suggestive as such. it would be pretty great if so. or are we meant to go in there and deal with npm related stuff too? asking for a friend who is not a fan of front end and who is also me.
The text was updated successfully, but these errors were encountered: