Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track forbidden/permission granted for major brands in data file #11270

Open
uncenter opened this issue Jun 18, 2024 Discussed in #11269 · 4 comments
Open

Track forbidden/permission granted for major brands in data file #11270

uncenter opened this issue Jun 18, 2024 Discussed in #11269 · 4 comments
Labels
docs Issues for improving or updating package documentation in discussion There is an ongoing discussion that should be finished before we can continue meta Issues or pull requests regarding the project or repository itself

Comments

@uncenter
Copy link
Member

uncenter commented Jun 18, 2024

Discussed in #11269

Originally posted by @jrhaberland June 18, 2024
I'm pretty sure this doesn't exist in the repository as I've looked pretty thoroughly for it. I feel like there should be some place that keeps a log of the companies that have given simple-icons permission to use their icons.

If it were to be made it should store the following:

  • Name of company
  • Date permission was granted
  • A copy of the email that gave said permission
  • Link to related issues and or PRs
  • Maybe a list of all the icons related with the company
@uncenter
Copy link
Member Author

Kinda piggybacking off of #9999, a _data/permissions.json file or similar would be nice to track explicitly forbidden brands or places were permission has been granted. I'm thinking something like the following:

[
  {
    "brand": "General Motors",
    "status": "approved", // or "denied" or "forbidden"
    "related": [8837, 3984], // list of related issues/PRs
    "context": [
      { type: "comment", content: "https://github.com/simple-icons/simple-icons/pull/11150#issuecomment-2174356643" }
    ],
  },
  // ...
]

@uncenter uncenter added docs Issues for improving or updating package documentation meta Issues or pull requests regarding the project or repository itself in discussion There is an ongoing discussion that should be finished before we can continue labels Jun 18, 2024
@jrhaberland
Copy link
Contributor

Maybe could add functionality to take and use that to create a regex that can be used with the auto closer bot github action.

@uncenter
Copy link
Member Author

Yep that's the idea of #9999.

@jrhaberland
Copy link
Contributor

This could also be a good way to test one of the different ways of changing the scheming of the json files as discussed in #9368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues for improving or updating package documentation in discussion There is an ongoing discussion that should be finished before we can continue meta Issues or pull requests regarding the project or repository itself
Projects
None yet
Development

No branches or pull requests

2 participants