Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wikimedia Commons #2615

Closed
PeterShaggyNoble opened this issue Feb 18, 2020 · 6 comments · Fixed by #2685
Closed

Wikimedia Commons #2615

PeterShaggyNoble opened this issue Feb 18, 2020 · 6 comments · Fixed by #2685
Assignees
@ericcornelissen
Labels
new icon Issues or pull requests for adding a new icon

Comments

@PeterShaggyNoble
Copy link
Member

Name: Wikimedia Commons
Website: https://commons.wikimedia.org/
Alexa Rank: n/a (Wikimedia subdomain)
Colour: #006699?
Official resources for icon and color: Icon from this file, colour from this one

Wikimedia Commons
@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Feb 18, 2020
@PeterShaggyNoble PeterShaggyNoble self-assigned this Feb 18, 2020
@PeterShaggyNoble PeterShaggyNoble added the in discussion There is an ongoing discussion that should be finished before we can continue label Feb 19, 2020
@PeterShaggyNoble
Copy link
Member Author

Just now noticing a number of differences between the 2 SVGs I linked above and trying to decide which is more "correct" seeing as they're both from official sources. I'd guess the full colour version but it includes a stroke which isn't playing nicely in Inkscape when converted to a path.

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Feb 19, 2020 •
edited

Though I would much prefer the version on the right (gray), I think we should go with the left version (coloured) given that it is prominently displayed on the homepage...

This might help you with your Inkscape problems @PeterShaggyNoble. If not, let me know and I will see if I can get it to work 🙂

@PeterShaggyNoble
Copy link
Member Author

The problem is in how Inkscape is converting the stroke to a path - the path (in red) doesn't quite line up with the original stroke as it curves around to meet the arrow at the top:

@PeterShaggyNoble PeterShaggyNoble removed their assignment Feb 22, 2020
@ericcornelissen
Copy link
Contributor

Took a shot at it, and I think it worked out decently. Can you compare it as well @PeterShaggyNoble? You can download the svg.zip here.

comparison

For the record, this logo is horrendously ugly... The stems of the arrows extend beyond the circle by a pixel 🙃

@PeterShaggyNoble
Copy link
Member Author

Looks spot on to me, Eric 👍 Unless you want to fix the issue with the arrows for them?

@ericcornelissen ericcornelissen removed the in discussion There is an ongoing discussion that should be finished before we can continue label Feb 26, 2020
@ericcornelissen ericcornelissen mentioned this issue Feb 26, 2020
Merged
3 tasks
@ericcornelissen
Copy link
Contributor

Unless you want to fix the issue with the arrows for them?

I opened the PR as is, if the consensus is to fix them up we can always do that later 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericcornelissen ericcornelissen

Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Wikimedia Commons
2 participants
@ericcornelissen @PeterShaggyNoble