Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Twinkly #3432

Closed
LazyTarget opened this issue Aug 7, 2020 · 11 comments · Fixed by #10485
Closed

Request: Twinkly #3432

LazyTarget opened this issue Aug 7, 2020 · 11 comments · Fixed by #10485
Labels
new icon Issues or pull requests for adding a new icon

Comments

@LazyTarget
Copy link

Name: Twinkly
Website: https://twinkly.com/
Alexa rank: https://www.alexa.com/siteinfo/twinkly.com

Official resources for icon and color:

https://play.google.com/store/apps/details?id=com.twinkly&hl=en
https://apps.apple.com/us/app/twinkly/id1132187056
https://twinkly.com/wp-content/themes/twinkly/assets/img/logo@2x.png

@LazyTarget LazyTarget added the new icon Issues or pull requests for adding a new icon label Aug 7, 2020
@NovaGL NovaGL added the out of scope Issues or pull requests that are beyond the scope of the project label Aug 9, 2020
@NovaGL
Copy link
Contributor

NovaGL commented Aug 9, 2020

Thanks for the request @LazyTarget

Unfortunately the Alexa ranking is too high for this to be considered.
If you can provide other metrics to show the popularity of this we can reconsider it.

@PeterShaggyNoble
Copy link
Member

The Alexa rank for this currently sits at ~123k. However, that may be a seasonal thing as it seems to be a product for controlling Christmas lights. Reopening for now so we can keep an eye on it over the next few weeks/months to see if it stays above our thresholds

@PeterShaggyNoble PeterShaggyNoble added pending Issues that are pending because of e.g. a scheduled brand update and removed out of scope Issues or pull requests that are beyond the scope of the project labels Jan 4, 2021
@service-paradis
Copy link
Member

More than a month later and it sits at ~150K. I think we can add this one!

@PeterShaggyNoble
Copy link
Member

Agreed, @service-paradis. So next we need to decide what to use for the icon. I'd suggest the tree icon seen in their favicon and app icons but I've yet to find a vector version of it.

@service-paradis
Copy link
Member

I also agree that we should use the tree icon. Unfortunately, did not find any good vector version of it anywhere!
Only a PNG version:
https://www.twinkly.com/wp-content/uploads/2019/09/twinkly-icon.png

@PeterShaggyNoble
Copy link
Member

Gave it a go myself and the result doesn't look to be too terrible but, given my poor track record at converting raster to vector, I could do with someone else throwing an eye over it before I start trying to clean it up and optimise it:

M 4.0701754,0 C 1.8152982,0 0,1.8152982 0,4.0701754 V 19.929825 C 0,22.184702 1.8152982,24 4.0701754,24 H 19.929825 C 22.184702,24 24,22.184702 24,19.929825 V 4.0701754 C 24,1.8152982 22.184702,0 19.929825,0 Z M 11.592996,2.9941749 C 11.677207,2.9941749 12.196459,3.4573099 12.411664,3.7192982 12.626869,3.9859649 13.047921,4.7578902 13.113418,5.0011649 13.132132,5.0853754 13.160243,5.1041211 13.22574,5.0807291 13.515799,4.9637702 13.885407,4.9122989 14.343887,4.9076207 15.07839,4.9076207 15.335664,4.987107 15.616365,5.3052358 16.051453,5.8011421 15.883046,6.4280474 15.069011,7.3917902 14.863162,7.6350649 14.690036,7.8503242 14.690036,7.8690379 14.690036,7.8877512 14.750873,8.0701435 14.825726,8.271313 15.092393,8.9917811 15.181309,9.7777596 15.06435,10.390625 14.975461,10.858461 14.638587,11.054975 14.142681,10.92866 13.384786,10.732168 12.668992,10.43273 12.336828,10.180099 12.229226,10.100567 12.112313,10.016402 12.079564,9.9930098 12.037459,9.9696179 11.89237,10.081844 11.621025,10.357867 11.181259,10.802312 10.29709,11.42458 9.9789611,11.504112 9.6234056,11.597679 9.2303958,11.438606 9.0385828,11.120477 8.8140214,10.760243 8.7157667,9.3239537 8.8654744,8.5847726 L 8.9309895,8.2573326 8.5614035,7.9064554 C 8.1076025,7.4713677 7.7754432,7.078367 7.5602386,6.7181333 7.2888933,6.2690105 7.3450154,5.8526042 7.7052495,5.5859375 7.9298109,5.4175165 8.2947414,5.2491456 8.6128702,5.1696133 8.9918175,5.0713677 9.7029467,5.0713677 10.081894,5.1696133 10.559087,5.2912509 11.087715,5.581314 11.457305,5.9228344 11.976604,6.4047056 11.906451,6.4608004 11.153235,6.1800986 10.65265,5.9976425 10.114593,5.9228025 9.7262884,5.9836211 9.4081596,6.0350832 8.9964958,6.1613761 8.9637474,6.2175165 8.9309986,6.2689786 9.4877512,6.68072 10.044476,7.0128839 10.601201,7.349726 10.807018,7.560234 10.807018,7.7894737 10.807018,7.8736842 10.755533,8.1637747 10.690036,8.4304414 10.624539,8.6971081 10.573122,8.9497214 10.573122,8.9965049 10.573122,9.0760372 10.577769,9.0760554 10.704085,8.9918449 10.77426,8.9403828 10.998853,8.7485379 11.204701,8.5614035 11.915812,7.9251463 12.145052,7.9298018 12.818736,8.5847726 13.249146,9.0011467 13.688884,9.3567025 13.773095,9.3567025 13.824557,9.3567025 13.829235,9.3052495 13.773095,9.0385828 13.712276,8.720454 13.571912,8.2198695 13.478344,7.9859512 13.450274,7.9110975 13.426878,7.7754477 13.426878,7.6818804 13.426878,7.5228161 13.473675,7.4619884 14.072506,6.877193 14.423383,6.530994 14.755555,6.1660909 14.807018,6.0678453 14.895906,5.894746 14.895938,5.88538 14.816406,5.8245614 14.601201,5.6654972 13.62807,5.6795277 13.192982,5.8432702 12.879532,5.9602295 12.856168,5.9649214 12.729852,5.8573189 12.654998,5.8011786 12.598808,5.6421189 12.514597,5.2772067 12.383603,4.687733 12.168421,4.2058298 11.859649,3.7941337 L 11.630414,3.4947231 11.522821,3.630414 C 11.326329,3.8643319 11.040945,4.5099232 10.980126,4.8467653 10.938021,5.0760053 10.900608,5.1696133 10.853824,5.1696133 10.591836,5.1696133 10.937984,3.9625593 11.410499,3.2140214 11.490031,3.092384 11.569604,2.9941749 11.592996,2.9941749 Z M 12.143572,11.746505 C 12.235529,11.741432 12.544326,12.10392 12.729852,12.463131 L 12.884183,12.757881 13.422218,12.93565 C 14.184791,13.183603 14.423387,13.305263 14.755551,13.614035 15.143855,13.978947 15.307593,14.301782 15.335664,14.76494 15.354377,15.087747 15.368412,15.120449 15.476014,15.162555 15.723967,15.256122 16.252622,15.541552 16.528646,15.728687 17.847944,16.617576 18.133361,18.03512 17.22108,19.167284 16.711139,19.798862 15.625713,20.360252 14.390625,20.626919 12.902906,20.949726 10.750877,21.001142 9.2631579,20.743832 8.6502923,20.640908 7.7613716,20.37892 7.3590323,20.182429 6.9613716,19.990616 6.5029284,19.588286 6.3672561,19.302906 6.2362618,19.040918 6.2362298,18.591822 6.3578674,18.348547 6.5590368,17.960243 7.0689923,17.62336 7.7052495,17.464295 8.1917993,17.33798 9.6234147,17.35206 10.573122,17.487733 11.770783,17.660832 13.464309,18.072524 13.54852,18.208196 13.567233,18.236266 13.539177,18.292411 13.492393,18.329838 13.417539,18.385979 13.197684,18.390648 12.046806,18.367256 10.109964,18.325151 8.9029056,18.423378 8.4257126,18.652618 8.1730811,18.778934 8.2011467,18.895915 8.5145972,19.050301 9.726293,19.65381 12.692393,19.555524 14.123972,18.867804 14.55906,18.661956 14.970751,18.269001 15.054962,17.983621 15.157886,17.632744 15.125128,17.356721 14.952028,17.001165 14.86314,16.823387 14.708804,16.598862 14.60588,16.500617 L 14.428043,16.327508 14.147341,16.463131 C 13.431552,16.818686 12.720445,16.954359 11.602316,16.954359 10.006995,16.94968 8.9449972,16.683027 8.3414884,16.126302 8.0795004,15.887706 8,15.733324 8,15.476014 8,14.778938 8.930994,14.45614 10.947368,14.45614 12,14.45614 13.389474,14.582456 14.035088,14.736842 14.470175,14.839766 14.45614,14.839766 14.45614,14.736842 14.45614,14.573099 14.283009,14.287728 14.095874,14.138021 13.744997,13.866676 12.725133,13.445628 12.687706,13.557908 12.6456,13.684224 12.238592,13.904103 11.878358,13.99767 11.349703,14.128664 10.605857,14.105268 10.278372,13.946204 9.9929916,13.805853 9.8011923,13.562555 9.8011923,13.337993 9.8011923,12.809339 10.577755,12.486568 11.672492,12.556744 11.929802,12.570779 12.219874,12.603527 12.31812,12.626919 12.547359,12.683059 12.547346,12.622195 12.304071,12.182429 12.201147,11.995294 12.116982,11.817544 12.116982,11.789474 12.116982,11.760965 12.126543,11.747444 12.143572,11.746505 Z M 11.307018,13.249726 C 11.037427,13.247972 10.776608,13.263167 10.666667,13.295915 L 10.502947,13.347382 10.713473,13.445587 C 11.003532,13.576581 11.667836,13.581309 12,13.450315 L 12.233895,13.361431 12,13.305236 C 11.854971,13.270148 11.576608,13.25148 11.307018,13.249726 Z M 10.295915,15.385554 C 9.8922993,15.388536 9.5897842,15.428947 9.4690242,15.508772 9.3661,15.574269 9.3567572,15.597642 9.4128975,15.653783 9.6982775,15.939163 12.051439,16.126298 12.93565,15.934485 13.141498,15.887701 13.328651,15.840945 13.352042,15.822231 13.412861,15.784805 13.052604,15.705286 12.182429,15.555578 11.50085,15.439789 10.814851,15.381719 10.295915,15.385554 Z

@PeterShaggyNoble PeterShaggyNoble removed the pending Issues that are pending because of e.g. a scheduled brand update label Feb 18, 2021
@jorgeamadosoria jorgeamadosoria self-assigned this Sep 24, 2021
@jorgeamadosoria
Copy link
Contributor

I mean it looks good to me. It's not like there are a lot of options for vector sources for this brand.
Question, why not choose a simpler one, like:
https://apps.apple.com/us/app/twinkly/id1132187056

Taking into consideration that we are forced to work with a raster source, maybe it would make sense to simplify said raster source.

@LazyTarget
Copy link
Author

Hi, this is currently at rank 300k and rising and will probably peak around Christmas time
Maybe time to take a look at this one again?

@adamrusted
Copy link
Member

This is well outside our contribution criteria, granted in July. Need to keep an eye on how much it peaks over the winter period.

@adamrusted
Copy link
Member

Well, colour me surprised! It's currently sat within scope - should anyone want to take this on!

@adamrusted
Copy link
Member

adamrusted commented Feb 8, 2024

We (myself and @PeterShaggyNoble) have found a vector source among these guides!
@simple-icons/maintainers

@adamrusted adamrusted mentioned this issue Feb 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants