Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: nrwl & nx icons #4767

Closed
brunano21 opened this issue Jan 14, 2021 · 8 comments · Fixed by #4860
Closed

Request: nrwl & nx icons #4767

brunano21 opened this issue Jan 14, 2021 · 8 comments · Fixed by #4860
Assignees
Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project new icon Issues or pull requests for adding a new icon

Comments

@brunano21
Copy link
Contributor

brunano21 commented Jan 14, 2021

Brand Name: nrwl/nx
Website: https://nx.dev/, https://nrwl.io/
Alexa rank: 171,689 (nx.dev) / 356,588 (nrwl.io)

Official resources for icon and color:
https://github.com/nrwl/nx/blob/master/images/nx-logo.png

@brunano21 brunano21 added the new icon Issues or pull requests for adding a new icon label Jan 14, 2021
@adamrusted
Copy link
Member

Hi @brunano21, thanks for the request. Would you be interested in contributing these icons yourself? If so, have a read through our contributing guidelines and be sure to add each icon as it's own Pull Request, so we can track them easier.


SVG of nx.dev logo found here, in header of site.
Hex of #143055 seems to be popular throughout site.

SVG of nrwl.io logo found here, in header of site.
Hex of #96D7E8 is used in site footer, and seems to match quite well to the SVG.

@adamrusted adamrusted added the good first issue Issues we believe are simple and a good first stab at contributing to the project label Jan 14, 2021
@brunano21
Copy link
Contributor Author

brunano21 commented Jan 15, 2021

@adamrusted thanks for taking this into consideration. Before doing that, do you believe I should request permission to the company for adding their logos to this repo?

EDIT: I have requested nrwl to provide the go-ahead for this matter.

@brunano21 brunano21 changed the title Add nrwl/nx icon Request: nrwl & nx icons Jan 15, 2021
@PeterShaggyNoble
Copy link
Member

I have requested nrwl to provide the go-ahead for this matter

Thanks, @brunano21, appreciate that. We don't have a firm rule on it but it never hurts to ask for permission from official sources.

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 15, 2021
@brunano21
Copy link
Contributor Author

brunano21 commented Jan 19, 2021

@adamrusted @PeterShaggyNoble I'm still waiting for a reply from nrwl.

However, in the meantime, I'm trying to follow the contributing guidelines and but I faced some difficulties in optimizing the icon with the SVGOMG Online Tool.
Specifically, I have followed the instructions and but when I download the optimized icon I can see there is more the one path element, despite the merge paths setting is enabled. Is there something else I should be taking into consideration?

Also, I'm having difficulties applying the viewbox="0 0 24 24". Doing so will cut most of the icon - so I guess there must be something wrong I'm doing.

FYI, I'm not an SVG expert, unfortunately.

@adamrusted
Copy link
Member

adamrusted commented Jan 19, 2021

Hi @brunano21, thanks for working on this. Which software have you been using to edit the SVG? Inkscape and Illustrator, for example, allow you to create a 'union' of the paths - before exporting it to SVGOMG.

Inkscape
Illustrator

That should take it down to one path before SVGOMG does it's work. While it's great at cutting down the filesize and generally optimizing the image, I don't tend to use it for path operations.

Regarding the viewBox size - if you set your canvas to 24*24px, and then resize the icon (keeping the aspect ratio the same) so that the longest edge is 24px, it should center just fine.

@brunano21
Copy link
Contributor Author

@adamrusted Oh I think I have entirely skipped the Extract the Icon from the Logo section! 😁
Let me give it a try.

@adamrusted adamrusted added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed and removed awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed labels Jan 19, 2021
@brunano21
Copy link
Contributor Author

Icons are ready, but no update from nwrl (@vsavkin @jeffbcross @kmaida) yet 🙄

@kmaida
Copy link

kmaida commented Jan 25, 2021

Hi @brunano21, I apologize for the delay. It is fine to add these logos. Thanks for asking!

@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 25, 2021
This was referenced Jan 25, 2021
@adamrusted adamrusted linked a pull request Jan 29, 2021 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues we believe are simple and a good first stab at contributing to the project new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants