Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 lacks dist folder #150

Closed
dominik-schmidt opened this issue Jun 21, 2016 · 5 comments
Closed

Release 2.0.0 lacks dist folder #150

dominik-schmidt opened this issue Jun 21, 2016 · 5 comments

Comments

@dominik-schmidt
Copy link

There is no dist folder here: https://github.com/simple-statistics/simple-statistics/tree/v2.0.0

(dist is still present in v2.0.0-beta.)

@tmcw
Copy link
Member

tmcw commented Jun 21, 2016

Hi Dominik,

This is intentional: dist is now gitignored but then specifically included with package.json so it is included in the npm package. This follows the suggested workflow of npmcdn, with the end result being:

  • Since dist files are no longer in git, there are no gnarly git conflicts when multiple PRs rebuild dist
  • Also less commit noise as people rebuild dist
  • But the dist file is still available if you clone & build, or if you use the npmcdn distribution.

@dominik-schmidt
Copy link
Author

Hi Tom, thanks for explaining!

@court-jus
Copy link

So how should we do if we are using bower ?

@tmcw
Copy link
Member

tmcw commented Jul 5, 2016

You can either

bower install https://github.com/simple-statistics/simple-statistics.git

Or use the CDN or something other than Bower. I'm sorry, but bower is a drag on my time and the time of other open source project owners, and it works against the flow of GitHub repos by requiring checked-in builds. Browserify, webpack, rollup, CDNs, JavaScript files - there are many other options, and I recommend any of them over Bower.

@tmcw
Copy link
Member

tmcw commented Jul 5, 2016

There's also a bower.zip located at https://npmcdn.com/simple-statistics@2.0.1/bower.zip

@tmcw tmcw closed this as completed Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants