feat: Implement log average #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2021 21:59
dsaxton
commented
Mar 1, 2021
| t.end(); | ||
| }); | ||
|
|
||
| t.test("does not overflow for large products", function (t) { |
There was a problem hiding this comment.
We can also remove this and the underflow test as they're a tad on the trivial side for this function (would be more interesting for geometricMean)
tmcw
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171
Adds a
logAveragefunction as an equivalent way of calculating the geometric mean. Also fixes what's arguably a bug ingeometricMeanwhere it throws an error for inputs containing zero instead of returning zero. InterestinglylogAveragestill handles that case correctly becauseMath.log(0)becomes-Infinity, andMath.exp(-Infinity)turns out to be zero.