Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Brave detection to our public script #538

Closed
adriaandotcom opened this issue Mar 4, 2021 · 1 comment
Closed

Add Brave detection to our public script #538

adriaandotcom opened this issue Mar 4, 2021 · 1 comment
Labels
public script Public JavaScript to collect data
Projects
Public roadmap

Comments

@adriaandotcom
Copy link
Contributor

Brave does have a check build in that shows if the browser is brave or not:

navigator.brave && navigator.brave.isBrave().then(function() {
  payload.browser_name = "Brave";
  triggerSendPageView();
}).catch(triggerSendPageView)

brave/brave-browser#10165 (comment)
@adriaandotcom adriaandotcom added the public script Public JavaScript to collect data label Mar 4, 2021
@adriaandotcom adriaandotcom added this to the Important milestone Mar 4, 2021
@adriaandotcom adriaandotcom added this to Features & bugs in Public roadmap via automation Mar 4, 2021
@adriaandotcom adriaandotcom removed this from the Important milestone Mar 4, 2021
@adriaandotcom
Copy link
Contributor Author

Duplicate of #609

@adriaandotcom adriaandotcom marked this as a duplicate of #609 Jun 28, 2021
Public roadmap automation moved this from Features & bugs to Implemented Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
public script Public JavaScript to collect data
Projects
Public roadmap
  
Implemented
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adriaandotcom