Skip to content
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.

Added \mathbb #51

Merged

Conversation

michaelniedermayr
Copy link
Contributor

Description

Added \mathbb{}.

Related issues

Checklist

  • I added a PR description.
  • I linked all related issues I could find.
  • If this PR changes anything about the main catex or example package (also README etc.),
    I created an entry in CHANGELOG.md (## NEXT RELEASE if it is not worth an update).
  • If this PR includes a notable change in the catex package, I updated the version according
    to Dart's semantic versioning.
  • If this PR adds new functions, I updated the function_prioritization.csv file.
  • I added tests covering all my additions (Golden tests for anything rendering related).
  • All required checks pass.

@cla-bot
Copy link

cla-bot bot commented Jul 5, 2020

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: michael.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contributing ❤

You added \mathbb to the TextNode, however, it appears to be a math-only function, which means that it should not trigger text mode.

Looking at https://github.com/KaTeX/KaTeX/blob/1eda0e86a0fec7eb42c22417b456ceed819984be/src/functions/font.js, you should probably move it to the FontNode instead 🙂

lib/src/lookup/functions.dart Outdated Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@creativecreatorormaybenot
Copy link
Contributor

creativecreatorormaybenot commented Jul 5, 2020

@michaelniedermayr It looks like you need to amend your commit in order to add an email. Note that you can add the GitHub no-reply email as well if you prefer that 🙃

(so amend the commit and recommit with the right config → force push)

@cla-bot
Copy link

cla-bot bot commented Jul 5, 2020

Thank you for your pull request and welcome to our community! We require contributors to sign our Contributor License Agreement (CLA) and we don't see to have you on file. In order for us to review and merge your code, please follow the link above. It should only take you 30 seconds to do so.

After you've read and accepted the CLA, please reply with @cla-bot check.

If you have a question don't hesitate to contact our team.

@creativecreatorormaybenot
Copy link
Contributor

@michaelniedermayr Awesome 👌🏽

Looks like you need to put your username into the form the CLA bot linked 😬

@michaelniedermayr
Copy link
Contributor Author

Just filled out the form. Hope that this time everything is correct.

@creativecreatorormaybenot
Copy link
Contributor

@cla-bot check

1 similar comment
@michaelniedermayr
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jul 5, 2020
@cla-bot
Copy link

cla-bot bot commented Jul 5, 2020

The cla-bot has been summoned, and re-checked this pull request!

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Jul 5, 2020

The cla-bot has been summoned, and re-checked this pull request!

@creativecreatorormaybenot creativecreatorormaybenot merged commit 3b12963 into simpleclub:master Jul 5, 2020
@creativecreatorormaybenot
Copy link
Contributor

Yep, very nice 🙌🏽 Next time, the cla thing is already set up 😄

Will be published in #50 - only waiting for a review 🙂

@creativecreatorormaybenot creativecreatorormaybenot mentioned this pull request Jul 5, 2020
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants