Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flutter_math_fork #30

Merged
merged 5 commits into from Mar 14, 2022
Merged

Update flutter_math_fork #30

merged 5 commits into from Mar 14, 2022

Conversation

edhom
Copy link
Member

@edhom edhom commented Mar 14, 2022

Description

This updates flutter_math_fork to the latest version.

Related issues & PRs

n/a

Checklist

  • I have made myself familiar with the CaTeX
    contributing guide.
  • I added a PR description.
  • I linked all related issues and PRs I could find (no links if there are none).
  • If this PR changes anything about the main math_keyboard or example package
    (also README etc.), I created an entry in CHANGELOG.md (## UPCOMING RELEASE if the change
    on its own is not worth an update).
  • If this PR includes a notable change in the math_keyboard package, I updated the version
    according to Dart's semantic versioning.
  • If there is new functionality in code, I added tests covering all my additions.
  • All required checks pass.

Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Two things that need to be done:

  1. Changelog entry
  2. Tests are failing on stable after the change 🤔

@edhom
Copy link
Member Author

edhom commented Mar 14, 2022

@creativecreatorormaybenot Oh I thought we don't add an entry for patches:D
The test were failing cause the latest version of flutter_svg is used, which requires flutter 2.5 iirc (see the use of LayerHandle). But the flutter-action workflow used in the checks used an old flutter version. Updating it fixed it:)

Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@edhom edhom merged commit c8106db into main Mar 14, 2022
@edhom edhom deleted the update-flutter-math-svg branch March 14, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants