Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery-3.4.1 contains vulnerabilities please upgrade to 3.5.1 #108

Open
jgarland79 opened this issue Jan 14, 2021 · 6 comments
Open

jquery-3.4.1 contains vulnerabilities please upgrade to 3.5.1 #108

jgarland79 opened this issue Jan 14, 2021 · 6 comments

Comments

@PragTob
Copy link
Collaborator

PragTob commented Jan 14, 2021

Hi, thanks for letting us know and we'll upgrade but as these are XSS vulnerabilities you'd need to look at somebody else's malicious code (as that's the user input we got) if that is even affected by this, or am I missing another attack vector here?

@jgarland79
Copy link
Author

@PragTob It doesn't seem to matter to our vulnerability scanner how it is used. Just that it is there and the code is flagged as vunlerable. :(

@PragTob
Copy link
Collaborator

PragTob commented Jan 15, 2021

Of course it doesn't matter for it :D So, your problem is more that your security scanner nags you about it than the actual security risk.

@snarfmason
Copy link

@PragTob hey, if I made a PR to update to jquery 3.5.1 would you accept the patch?

@neilsy
Copy link

neilsy commented Oct 25, 2021

@PragTob I've made a PR to update the emdbedded jquery here: #115
I am not quite sure the process for contributing...
I did run simplecov tests with the updated simplecov-html gem loaded from my local code. I also tested with my own code, generating a full coverage report on a suite of tests.

@neilsy
Copy link

neilsy commented Dec 6, 2021

@PragTob Do you have time to check this out? #115
It would help my team a lot if we could comply with my company's security policies without begging for exceptions! Probably there are many others in the same boat now, with off-the-shelf scans becoming standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants