Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename adapter to profile #205

Closed
mikerobe opened this issue Feb 20, 2013 · 3 comments
Closed

Rename adapter to profile #205

mikerobe opened this issue Feb 20, 2013 · 3 comments

Comments

@mikerobe
Copy link
Contributor

I was confused by the use of the word "adapter" when describing what looked to me like collections of pre-defined settings. That's more typically called a "profile." These are really not adapters. Adapters change the interface of something, which isn't what these things are doing. They're just adding settings and keeping the interface the same.

So it should be load_profile 'rails' and SimpleCov.profiles.define 'foo'

@colszowka
Copy link
Collaborator

Yup, that seems reasonable. Would you be interested in submitting a pull request for this? Should be rather straight forward by replacing the few definitions, but I think this would need a deprecation fallback that still supplies the current methods but prints a warning that this will be removed soon and forwards them to the profile-named ones.

@mikerobe
Copy link
Contributor Author

Sure, no problem. I'll see if I can submit something today

Pull request #207

@colszowka
Copy link
Collaborator

Merged the PR #207, closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants