simplecov BREAKS rspec

[danielb2]

require 'simplecov'
SimpleCov.start
describe 'exit status' do
  it "should exit with a non-zero exit status when assertion fails" do
    1.should == 2
  end
end

Put the above code in a file, run the file.

echo $?
=> 0

it should return 1

[danielb2]

Example run:

[~/tmp]$ rspec exit_status_spec.rb 
F

Failures:
  1) exit status should exit with a non-zero exit status when assertion fails
    Failure/Error: 1.should == 2
    expected: 2,
          got: 1 (using ==)
    Diff:
    @@ -1,2 +1,2 @@
    -2
    +1
    # ./exit_status_spec.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.00226 seconds
1 example, 1 failure
Coverage report generated for /Users/daniel/.rvm/gems/ruby-1.9.2-p0/bin/rspec exit_status_spec.rb to /Users/daniel/tmp/coverage

[~/tmp]$ echo $?
0

[colszowka]

I see. This might have to do with the at_exit handler in simplecov not propagating RSpecs actual exit status correctly.

I will have a look, thanks for reporting this!

[colszowka]

Make sure the correct exit status is propagated from tests when running
simplecov.

Closed by 20d6a8c

[colszowka]

This bug should be fixed with version 0.3.5. It seems that the wrong return code only appeared when not invoking tests via rake. Unit tests for this specific error are included and this should work as expected from now on. Sorry for the trouble.

[danielb2]

cool, thanks :)

[danielb2]

confirmed working, btw

[colszowka]

Great, thanks for confirming and the error report :)