-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser caching #18
Comments
Perhaps that should have made that a variable so we do not have to edit all those files everytime |
@Spuds I can do that, if you think it's fine :) |
Done: I'm sure I've missed many things, but I wanted to be sure that it's fine this way before I start editing the other cache versions. :) |
There are many other places where ?fin20 is used, not only index template. Also, I don't think yet another global like this is an answer, we're trying to remove them globals, not add to them. |
I understand. :) But a question though, in which file should it be put? I was thinking of using the context variable, but that one is defined later in index.php so I didn't know if it would be fine there. What do you think? |
My gut reaction was not to use a global (well once I saw it of course). There are well over 40 places that ?fin20 is used, which is why they are missed from time to time :P Don't know how folks feel about defining a constant for this purpose define('SMF_BROWSER_SALT', '?dev21') or some such thing. Don't know really. |
A constant sounds good to me :) |
str_replace(' ', '', $context['forum_version']); :P |
I did consider that, but thought it was a bit clunky, even fro 2,1 :P |
Looks like we are going to leave this old school for this round ... find/replace |
We will need to change ?fin20 to alpha1 (or dev), for the first community tests. Possibly other small versioning stuff.
The text was updated successfully, but these errors were encountered: