-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CONTRIBUTING file #192
Comments
Sounds great |
agreed ... looking forward to your addition |
I agree. Any reason why it isn't yet? |
Need to ask someone with Admin privileges ... |
I did it. Can you check it? Spuds, I will set you up as an admin. |
At one time I had admin on the repo but it was removed which is 🆒 with me .... l, would have like to have been informed but thats another story for another day. So please no need to make me an admin, someone had an issue/concern with that and I can do what I need to get done w/o that access 😃 |
Pretty sure I left ya admin when I made 2.1 repo and didn't change it. @joshuaadickerson actually, my apologies for the confusion: the current development branch is not 'development', it's 'release-2.1'. I think that is better off set as default for now. It will be the first to appear when you make a PR, it's simply easier. And busier for a while, as it should be. |
Spuds, you are an admin already. I'll let you set the repository to what you feel is best. |
iirc, I removed Spuds as an admin because the group controls everything, not just this repository. I'm fine with leaving it, but that's the reason why (again, iirc). Also, SleePy should be removed from the administrators, since he's not on the team anymore? |
Like I said, no need to add me back ... or now since its done remove me (again) 😄 Its all good |
@Fustrate, not having as admins the developers in charge while having non-developers as admins to code repositories themselves, for some odd reasoning with historical bias, is off topic and as far as I can see, it's detracting from solving very simple issues at hand:
I'd appreciate an answer that has something to do with solving the problem. :) It is relevant for contributors and potential contributors from the community. |
I noticed we have confusion over how to contribute to the SMF code. It seems like we could do something to make this easier.
First,
https://github.com/blog/1184-contributing-guidelines
This seems like a good idea and could help clear up questions and problems with how to contribute to the code.
Secondly,
If master is not going to be our development branch, we should set the development branch as our default branch. This can be done via the admin area.
The text was updated successfully, but these errors were encountered: