Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CONTRIBUTING file #192

Closed
jdarwood007 opened this issue Sep 18, 2012 · 12 comments
Closed

Add a CONTRIBUTING file #192

jdarwood007 opened this issue Sep 18, 2012 · 12 comments
Milestone

Comments

@jdarwood007
Copy link
Member

I noticed we have confusion over how to contribute to the SMF code. It seems like we could do something to make this easier.

First,
https://github.com/blog/1184-contributing-guidelines

This seems like a good idea and could help clear up questions and problems with how to contribute to the code.

Secondly,
If master is not going to be our development branch, we should set the development branch as our default branch. This can be done via the admin area.

@joshuaadickerson
Copy link
Contributor

Sounds great

@Spuds
Copy link
Contributor

Spuds commented Sep 22, 2012

agreed ... looking forward to your addition

@norv
Copy link
Contributor

norv commented Oct 19, 2012

If master is not going to be our development branch, we should set the development branch as our default branch. This can be done via the admin area.

I agree. Any reason why it isn't yet?

@Spuds
Copy link
Contributor

Spuds commented Oct 20, 2012

Need to ask someone with Admin privileges ...

@joshuaadickerson
Copy link
Contributor

I did it. Can you check it? Spuds, I will set you up as an admin.

@Spuds
Copy link
Contributor

Spuds commented Oct 20, 2012

At one time I had admin on the repo but it was removed which is 🆒 with me .... l, would have like to have been informed but thats another story for another day. So please no need to make me an admin, someone had an issue/concern with that and I can do what I need to get done w/o that access 😃

@norv
Copy link
Contributor

norv commented Oct 21, 2012

Pretty sure I left ya admin when I made 2.1 repo and didn't change it.

@joshuaadickerson actually, my apologies for the confusion: the current development branch is not 'development', it's 'release-2.1'. I think that is better off set as default for now. It will be the first to appear when you make a PR, it's simply easier. And busier for a while, as it should be.

@joshuaadickerson
Copy link
Contributor

Spuds, you are an admin already. I'll let you set the repository to what you feel is best.

@Fustrate
Copy link
Contributor

iirc, I removed Spuds as an admin because the group controls everything, not just this repository. I'm fine with leaving it, but that's the reason why (again, iirc).

Also, SleePy should be removed from the administrators, since he's not on the team anymore?

@Spuds
Copy link
Contributor

Spuds commented Oct 22, 2012

Like I said, no need to add me back ... or now since its done remove me (again) 😄 Its all good

@norv
Copy link
Contributor

norv commented Oct 23, 2012

@Fustrate, not having as admins the developers in charge while having non-developers as admins to code repositories themselves, for some odd reasoning with historical bias, is off topic and as far as I can see, it's detracting from solving very simple issues at hand:

the current development branch is not 'development', it's 'release-2.1'. I think that is better off set as default for now. It will be the first to appear when you make a PR, it's simply easier. And busier for a while, as it should be.

I'd appreciate an answer that has something to do with solving the problem. :) It is relevant for contributors and potential contributors from the community.
It's fine if you disagree, however do consider the context (current focus of development, user community around the project, starting up contributions, set up but not fully understood process, starting up with git and github), when taking this little detail into account. Thank you.

@ghost ghost closed this as completed Jul 22, 2013
@live627 live627 modified the milestones: release-2.1, Beta 1 Sep 9, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants