Unapproving topic in Recycle bin causes error or negative numbers

[jdarwood007]

Description

If you try to unapprove a topic in the recycle bin a error can occur. On some forums, due to database types, it can cause a negative number as well.

Steps to reproduce

1. Create topic
2. Delete topic (Ensuring Recycle Bin feature enabled)
3. Unapprove topic

In my testing:

BIGINT UNSIGNED value is out of range in '(`smf21git`.`smf_boards`.`num_posts` + -(1))'
File: /Sources/Subs-Post.php
Line: 2571


UPDATE smf_boards
SET num_posts = num_posts + -1, unapproved_posts = unapproved_posts + 1,
num_topics = num_topics + -1, unapproved_topics = unapproved_topics + 1
WHERE id_board = 15

On other boards, it seems to allow it to go to -1

Environment (complete as necessary)

• Version/Git revision: 2.1.4
• Database Type: Mysql
• Database Version: 8.0
• PHP Version: 8.1

Additional information/references

[jdarwood007]

This might be better to set the query to do something like:

num_topics = MAX(0, num_topics + -1), unapproved_topics = MAX(0, unapproved_topics + 1) ```