Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote selected text does not parse [member] BBC #7837

Closed
live627 opened this issue Sep 10, 2023 · 2 comments
Closed

Quote selected text does not parse [member] BBC #7837

live627 opened this issue Sep 10, 2023 · 2 comments
Labels
Milestone

Comments

@live627
Copy link
Contributor

live627 commented Sep 10, 2023

The fix is to change the output in parse_bbc

from

<a class="mention" href="https://www.simplemachines.org/community/index.php?action=profile;u=154736">@live627</a>

to

<a data-mention="154736" data-type="mention" class="mention" href="https://www.simplemachines.org/community/index.php?action=profile;u=154736">@live627</a>
@live627 live627 added the BBC label Sep 10, 2023
@jdarwood007
Copy link
Member

This was broken in 2.1.3. It was mentioned in the beta topic (msg 4138946) and I mentioned that fix.

SCeditor needs changed to do

			return '<a href="' + smf_scripturl +'?action=profile;u='+ attrs.defaultattr + '" class="mention" data-type="mention" data-mention="'+ attrs.defaultattr + '">@'+ content.replace('@','') +'</a>';

The bug was introduced in #7463

@jdarwood007 jdarwood007 added this to the 2.1.5 milestone Sep 11, 2023
@live627
Copy link
Contributor Author

live627 commented Sep 11, 2023

@live627 live627 closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants