Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some requests not using data compression (Accept-Encoding) #863

Closed
mboelen opened this issue Apr 18, 2024 · 4 comments
Closed

Some requests not using data compression (Accept-Encoding) #863

mboelen opened this issue Apr 18, 2024 · 4 comments

Comments

@mboelen
Copy link

mboelen commented Apr 18, 2024

Seeing in our logs that SimplePie is trying to get the feed. That goes well.

Then it follows with two requests. Both are blocked, as we don't allow uncompressed requests (Accept-Encoding).

Is the handler that pulls in the / URL and the favicon using a different set of options (HTTP protocol is different as well)?

2024-04-18T18:12:43+00:00 200 1.2.3.4 "GET /feed/ HTTP/2.0" 21552 "https://linux-audit.com/feed/" "FoF SimplePie/1.5.6 (Feed Parser; http://simplepie.org; Allow like Gecko) Build/20230917075900" TLSv1.3/TLS_AES_256_GCM_SHA384 0.000 .
2024-04-18T18:12:43+00:00 426 1.2.3.4 "GET / HTTP/1.1" 16 "-" "FavIcon/1.0 (Caching Utility; ; Allow like Gecko) Build/20160424000000" TLSv1.3/TLS_AES_256_GCM_SHA384 0.000 .
2024-04-18T18:12:43+00:00 426 1.2.3.4 "GET /favicon.ico HTTP/1.1" 16 "-" "FavIcon/1.0 (Caching Utility; ; Allow like Gecko) Build/20160424000000" TLSv1.3/TLS_AES_256_GCM_SHA384 0.000 .
@jtojnar
Copy link
Contributor

jtojnar commented Apr 18, 2024

That sounds like that is an issue with a SimplePie fork used by http://feedonfeeds.com/, which looks pretty dead.

I just tried with current SimplePie version (1.8.0) and the following example fetched the feed successfully:

<?php
declare(strict_types=1);
require_once __DIR__ . '/vendor/autoload.php';

use SimplePie\SimplePie;
$url = 'https://linux-audit.com/feed/';
$parser = new SimplePie();
$parser->set_feed_url($url);
$parser->init();
foreach ($parser->get_items() as $item) {
    var_dump($item->get_content());
}

@jtojnar
Copy link
Contributor

jtojnar commented Apr 18, 2024

FavIcon/1.0 (Caching Utility) definitely has nothing to do with SimplePie.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 18, 2024

Looks like this fork based on the SimplePie version and the presence of Caching Utility: https://github.com/RomanSixty/Feed-on-Feeds

@mboelen
Copy link
Author

mboelen commented Apr 19, 2024

Thanks @jtojnar for checking this out. I saw the 'FoF' but did not had a clue what it was. With your reference it makes sense that this is the project you listed. Strange that they mention SimpliePie so clearly and did not take the time to put up correct references to their own project.

I say we close this, as it clearly something outside this project. Thanks again!

@mboelen mboelen closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants