Broken metarefresh in 1.19.2 and 1.19.3 releases

[frnktrgr]

Describe the bug
The metarefresh module is not correctly installed under modules directory and therefore not working.
It is now located in vendor/simplesamlphp/simplesamlphp-module-metarefresh.

Details
In commit 4ee246c the required version of simplesamlphp/simplesamlphp-module-metarefresh was bumped from ^0.9 to ^1.0. Version 1.0.1 requires dev-master of simplesamlphp/simplesamlphp; therefore version 1.0.0 got packaged in releases 1.19.2 and 1.19.3.

Version 1.0.0 has the following type in composer.json:

    "type": "simplesamlphp-metarefresh",

instead of

    "type": "simplesamlphp-module",

IMHO (having no deeper knowledge about plugin installation ;-)): this breaks the installation.

Proposal
Switch back to version ^0.9 of simplesamlphp-module-metarefresh. Verified with:

composer require simplesamlphp/simplesamlphp-module-metarefresh ^0.9
php composer.phar install

[tvdijen]

Yes, this clearly breaks stuff and feels like a silent by-effect of some search&replace action.. Very unfortunate. Thanks for reporting this, and we'll try and fix this ASAP

[tvdijen]

The proposed solution is in fact solid.. The dependency should have never been raised to 1.0.. It's a mistake
Tag v1.0.0 was removed for that reason.. v1.0.1 is fine for use with SSP master

[iamCristYe]

possible to release a 1.19.4 to fix this?

[drjayvee]

Can this be released please?

I upgraded from 1.19.1 to solve the Warning: session_create_id(): Failed to create new ID warnings, only to find out that this issue made things even worse (users couldn't log in at all because the metadata wasn't getting refreshed).

I'd argue that either 1.19.4 should be released ASAP, or that 1.19.2 and 1.19.3 be unpublished.

[tvdijen]

Should be fixed in 1.19.4

[drjayvee]

I just did a quick test, and metarefresh works in 1.19.4.