Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleSAMLphp Metadata Signing Algorithm is not user configurable #411

Closed
sosumi opened this issue Jun 30, 2016 · 1 comment
Closed

SimpleSAMLphp Metadata Signing Algorithm is not user configurable #411

sosumi opened this issue Jun 30, 2016 · 1 comment

Comments

@sosumi
Copy link

sosumi commented Jun 30, 2016

The automated metadata signing algorithm is not user configurable.

While SAML assertion signing preferences can be configured in config/authsources.php to use either SHA-1 or SHA-2, with the stated intent (as I understand it) being to change the default to SHA-2 in SimpleSAMLphp 2.0, metadata signing is currently hard-coded to use SHA-1.

As far as I can tell, this is set in a combination of the files “simplesamlphp-[version]/lib/SimpleSAML/XML/Signer.php” (around lines 99 and 249) and “simplesamlphp-[version]/lib/SimpleSAML/Metadata/Signer.php” (around lines 190 and 210).

@jaimeperez
Copy link
Member

Thanks @sosumi!

I've just committed an implementation for this. Check the documentation for the development version (advanced features, metadata signing) to see how to specify the algorithm.

Please tell me if it works for you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants