Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[module] VOOT module for simpleSAMLphp (was #558) #47

Closed
sspghost opened this issue Feb 27, 2014 · 6 comments
Closed

[module] VOOT module for simpleSAMLphp (was #558) #47

sspghost opened this issue Feb 27, 2014 · 6 comments

Comments

@sspghost
Copy link

From mooknarf@gmail.com on July 26, 2013 10:28:14

I've created a simpleSAMLphp module to integrate with VOOT services protected with OAuth 2.0. The module retrieves group membership information from the VOOT provider and adds the groups to the SAML attributes.

The code currently can be found here: https://github.com/fkooman/ssp-voot-groups There are some releases available and they work fine for our (OpenConext/SURFconext) VOOT services.

I would like to add this module to simpleSAMLphp if there are more potential users of this module.

Original issue: http://code.google.com/p/simplesamlphp/issues/detail?id=558

@sspghost
Copy link
Author

From jaim...@gmail.com on February 03, 2014 09:26:44

Hi François!

Still interested in having this module integrated with the SSP standard distribution? If so, could you please prepare some documentation that we can include with the module? Given the great work you've done already with that, I guess it might be just adapting the existing docs to markdown...

Status: Accepted

@thijskh
Copy link
Member

thijskh commented Oct 6, 2014

I think SURFnet is still interested to have this module available in SSP. What kind of documentation are you looking for? I think README.md already has what you need to know.

@jaimeperez
Copy link
Member

Hi Thijs,

Things have changed a bit since then. Since we are trying to move more and more towards composer, the preferred way to go would be that modules that are not really basic for SimpleSAMLPHP or whose target audience is a small subset of our users, would be maintained by their owners as external modules installable with composer.

That given, the only thing that we would need then is to make sure the VOOT module is installable with composer, using the composer module installer.

We are also considering having some list of modules somewhere (website? something distributed with SimpleSAMLphp itself?), providing basic information about them and simple instructions on how to install them.

@thijskh
Copy link
Member

thijskh commented Oct 24, 2014

Hi Jaime,

Alright, I've tried this now on https://github.com/OpenConextApps/ssp-voot-groups and it does indeed seem to work.

What I'm indeed missing a bit is the 'discoverability' you talk about in the last paragraph. Maybe just start with a simple webpage on simplesamlphp.org linked from the main menu ("Modules")?

@jaimeperez
Copy link
Member

Hi Thijs!

Yes, I agree with you. I think we should provide such a list, and the webpage is the natural place for it, regardless of any other places we could consider for it. I'll put it in my to-do list 👍

@jaimeperez
Copy link
Member

Done! 😄

https://simplesamlphp.org/modules

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants