Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed packaging from pom/jar to apklib on google-play-services #70

Merged
merged 2 commits into from Dec 5, 2012

Conversation

nicstrong
Copy link
Contributor

In revision 3 of the google-play-services the packaging was changed from jar to apklib to support the new Google Maps functionality.
This commit updates the packaging.

In revision 3 of the google-play-services  the packaging was changed from jar to apklib to support the new Google Maps functionality.
This commit updates the packaging.
mosabua added a commit that referenced this pull request Dec 5, 2012
Changed packaging from pom/jar to apklib on google-play-services
@mosabua mosabua merged commit 4dc15b4 into simpligility:master Dec 5, 2012
@mosabua
Copy link
Member

mosabua commented Dec 5, 2012

I am gonna test and update the readme..

@nicstrong
Copy link
Contributor Author

I just updated the readme seconds before you merged :)

@mosabua
Copy link
Member

mosabua commented Dec 5, 2012

hahah... awesome.. I told @JakeWharton on g+ already ;-)

@schildbach
Copy link

Thanks for the work on this issue. Unfortunately the issue is not completely resolved. Currently, you need to add two dependencies to your project:

    <dependency>
        <groupId>com.google.android.gms</groupId>
        <artifactId>google-play-services</artifactId>
        <version>3</version>
        <type>jar</type>
    </dependency>

    <dependency>
        <groupId>com.google.android.gms</groupId>
        <artifactId>google-play-services</artifactId>
        <version>3</version>
        <type>apklib</type>
    </dependency>

Although the original Android Libraries do not support binaries, the apklib format does. So it would be preferable to only have the apklib dependency.

@schildbach
Copy link

Maybe I'm wrong on my last comment. It looks like the libs/ folder in apklibs is only used for native libraries, not for jar'ed class files. Does anyone know for sure?

@nicstrong
Copy link
Contributor Author

Maybe it will work, I think the native libs directory can be used to package Jars that the source has dependencies on.

On Thursday, 6 December 2012 at 1:06 AM, Andreas Schildbach wrote:

Maybe I'm wrong on my last comment. It looks like the libs/ folder in apklibs is only used for native libraries, not for jar'ed class files. Does anyone know for sure?


Reply to this email directly or view it on GitHub (#70 (comment)).

@nicstrong nicstrong mentioned this pull request Dec 5, 2012
@mosabua
Copy link
Member

mosabua commented Dec 6, 2012

From my understanding you need both..

@JakeWharton
Copy link
Contributor

We should be properly excluding the libs/ folder from the bundled 'apklib' with:

<nativeLibrariesDirectory>ignored</nativeLibrariesDirectory>

and then adding a dependency to the 'jar' from the 'apklib' so you only have to pull in one thing.

@schildbach
Copy link

GPS version 4 has been released.

@nicstrong
Copy link
Contributor Author

Unless the structure has changed it should still work as the version is read from sources.properties.

@mosabua
Copy link
Member

mosabua commented Dec 13, 2012

@Goonie can you try and provide a pull request if anything fails... I am flat out atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants