Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craft 4: Pins No Longer Loading #36

Closed
brettburwell opened this issue Aug 30, 2022 · 7 comments
Closed

Craft 4: Pins No Longer Loading #36

brettburwell opened this issue Aug 30, 2022 · 7 comments

Comments

@brettburwell
Copy link

Hi y'all. I was excited to see the Craft 4 release a few days ago. Congrats on getting that out the door.

Testing just now I'm having an issue where pins from previously created entries aren't loading when viewing my Donkeytail fields in the control panel. It's worth noting that this is happening in a Donkeytail field within a Matrix block.

Everything seems to work correctly when I create a new Matrix field (I'm able to select a canvas and then select entries to pin onto the canvas). I can save the entry and see everything output correctly on the front end.

But when I reload the entry in the control panel (or view any entries I previously created before upgrading) the pins no longer load onto the canvas. Here's an image for reference.

donkey-tail-no-pins

System Specs

  • Craft 4.2.3
  • PHP 8.0.21
  • MySQL 10.3.35
  • Donkeytail 3.0.0

There aren't any obvious errors in the dev tools console or Craft logs that I'm seeing. If there's any other info I can pass along that'd be helpful please let me know.

@andrewmenich
Copy link
Contributor

Hey @brettburwell thanks for reporting this issue. I will look into it now!

@brettburwell
Copy link
Author

Awesome. Thanks @andrewmenich.

@andrewmenich
Copy link
Contributor

@brettburwell I believe I've identified the issue. You can test the fix out locally by adding "simplygoodwork/craft-donkeytail": "dev-craft-4-develop as 3.0.0" to your composer.json. I'll cut a new release here shortly, unless you find this hasn't resolved the issue!

@brettburwell
Copy link
Author

@andrewmenich That looks like it did the trick. Thanks for the quick fix! Much appreciated.

@brettburwell
Copy link
Author

One other small thing. Maybe I'm misremembering, but previously when you clicked on an entry in the "Pins" column it would auto-select the corresponding pin on the canvas. That doesn't appear to be working any longer.

If you'd prefer I open another GitHub issue (or if I'm making up features that don't exist) let me know!

@andrewmenich
Copy link
Contributor

Resolved in v3.0.1. Thanks again for the report.

Also, I don't believe it did, but it does now 🙂

@brettburwell
Copy link
Author

Amazing! Thanks again @andrewmenich.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants