Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using shoryuken instead of sidekiq #49

Closed
oyeanuj opened this issue Jan 23, 2019 · 5 comments
Closed

Using shoryuken instead of sidekiq #49

oyeanuj opened this issue Jan 23, 2019 · 5 comments
Labels

Comments

@oyeanuj
Copy link

oyeanuj commented Jan 23, 2019

Hi @brianpattison! Thank you for creating this library - it looks great. I'd love to use it but I'm using shoryuken instead of sidekiq.

I was wondering if this can be used with shoryuken instead of sidekiq? Are the specific tweaks or settings that might make it possible?

Thanks!

@oyeanuj
Copy link
Author

oyeanuj commented Jan 23, 2019

FWIW, Shoryuken wiki says that they are a drop-in replacement for Sidekiq: https://github.com/phstc/shoryuken/wiki/From-Sidekiq-to-Shoryuken

@brianpattison
Copy link
Collaborator

Hey @oyeanuj,

Thanks for the kind words, we love Simple Scheduler and continue to use it in production for managing around a dozen different scheduled jobs that might run every 15 minutes or once a week.

We unfortunately do not support Shoryuken because we do use a couple Sidekiq APIs directly. Since we don't use Shoryuken at Simply Made Apps, we would rely on the community to submit a pull request to support it.

Our main interaction with Sidekiq's APIs is with the Sidekiq::ScheduledSet. You can see where we reference it here in the SimpleScheduler::Task class. We use the data in the scheduled set to keep track of scheduled jobs so we don't need a database component to keep track of whether the jobs run on time successfully. If you were to fork the project and were looking to add support for Shoryuken, this would be where you need to start. You would need an equivalent way to peek into the scheduled jobs via Shoryuken instead of Sidekiq.

We're happy to help with any questions you might have if you decide you want to take this on!

@oyeanuj
Copy link
Author

oyeanuj commented Jan 23, 2019

Ah, thank you for that context. I'm not super savvy with Shoryuken so I'll have to investigate more.

Maybe @phstc, the author of Shoryuken might have more thoughts.

@phstc
Copy link

phstc commented Jan 24, 2019

@oyeanuj there are some projects for Shoryuken, but I haven't used any. So I can't give further guidance.

But if you are using Heroku, can't you just call a rake task to enqueue a job every N minutes?

In AWS, I would use CloudWatch events.

@brianpattison
Copy link
Collaborator

Feel free to reopen this issue if you have more questions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants